netdev - Re: [OpenWrt-Devel] [RFC][PATCH 2/2] bgmac: pass received packet to the netif instead of copying it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520CBFD6.6030600@openwrt.org>
Date:	Thu, 15 Aug 2013 13:47:34 +0200
From:	Felix Fietkau <nbd@...nwrt.org>
To:	OpenWrt Development List <openwrt-devel@...ts.openwrt.org>
CC:	Rafał Miłecki <zajec5@...il.com>,
	Network Development <netdev@...r.kernel.org>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jonas Gorski <jogo@...nwrt.org>,
	Robert Bradley <robert.bradley1@...il.com>
Subject: Re: [OpenWrt-Devel] [RFC][PATCH 2/2] bgmac: pass received packet
 to the netif instead of copying it

On 2013-08-15 1:36 PM, Rafał Miłecki wrote:
> 2013/8/11 Rafał Miłecki <zajec5@...il.com>:
>> It makes more sense to allocate new (empty) skb and pass it to the
>> hardware. That way we avoid copying whole packet into new skb which
>> should result in better performance.
> 
> I did some testing of this patch using "perf" tool and iperf -s
> running on the OpenWrt machine (with bgmac supported hardware).
> 
> So you can see that __copy_user_common usage has really decreased with
> this patch!
> 
> Unfortunately it didn't result in better performance... no idea why :(
Running iperf on the router is not useful as an indicator of routing
performance. Please focus on tests where you only push traffic through
the router, not directly to it.

- Felix

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html