netdev - Re: [PATCH net-next 2/2] ipv4: processing ancillary IP_TOS or IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1376627705.4648.5.camel@edumazet-glaptop>
Date:	Thu, 15 Aug 2013 21:35:05 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Francesco Fusco <ffusco@...hat.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] ipv4: processing ancillary IP_TOS or IP_TTL

On Wed, 2013-08-14 at 17:48 +0200, Francesco Fusco wrote:

> @@ -1511,6 +1517,11 @@ void ip_send_unicast_reply(struct net *net, struct sk_buff *skb, __be32 daddr,
>  	inet = &get_cpu_var(unicast_sock);
>  
>  	inet->tos = arg->tos;
> +
> +	ipc.tos = ip_hdr(skb)->tos;

Why both inet->tos and ipc.tos must be set ?

This is very confusing, as if you were not 100% sure of your patch.


> +	ipc.ttl = inet->uc_ttl;

	ipc.ttl = -1;

> +	ipc.priority = skb->priority;
> +
>  	sk = &inet->sk;
>  	sk->sk_priority = skb->priority;

Why both sk->sk_priority and ipc.priority must be set ?

>  	sk->sk_protocol = ip_hdr(skb)->protocol;



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html