netdev - Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130816055440.GA2458@electric-eye.fr.zoreil.com>
Date:	Fri, 16 Aug 2013 07:54:40 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	hayeswang <hayeswang@...ltek.com>
Cc:	netdev@...r.kernel.org, "'nic_swsd'" <nic_swsd@...ltek.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	"'David Miller'" <davem@...emloft.net>
Subject: Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

hayeswang <hayeswang@...ltek.com> :
> Francois Romieu [mailto:romieu@...zoreil.com] 
[...]
> > The forward declaration is not needed.
> 
> The r8152_submit_rx() need the declaration of read_bulk_callback(), and the
> read_bulk_callback() need the declaration of r8152_submit_rx(), too. It likes
> a dead lock, so I have no idea how to do it without another declaration.

Ok, send me a brain for Xmas.

[...]
> > How is it related to the subject of the patch ?
> 
> When link down, the driver would cancel all bulks. This avoid the re-submitting
> bulk.

It's quite orthogonal to aggregation and could thus had been done in its own
patch for readability sake.

[...]
> > It should be possible to retrieve more items in the spinlocked section
> > so as to have a chance to batch more work. I have not thought 
> > too deeply
> > about it.
> 
> I only lock when I want to remove or inser the agg list, and unlock as soon as
> possible. I don't think I keep locking for a long time.

Sure. It doesn't make a difference if tp->rx_done doesn't grow much.

Thanks.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html