| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Aug 2013 16:52:13 +1000 From: Martin Schwenke <martin@...tin.net> To: Stephen Hemminger <stephen@...workplumber.org> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] ip monitor: Enable prefix labels when monitoring more than 1 object On Thu, 15 Aug 2013 23:40:47 -0700, Stephen Hemminger <stephen@...workplumber.org> wrote: > On Thu, 15 Aug 2013 07:05:27 +1000 > Martin Schwenke <martin@...tin.net> wrote: > > > Prefix labelling is currently only activated when monitoring "all" > > objects. However, the output can still be confusing when monitoring > > more than 1 object, so enable prefix labels in this case. > > > > Signed-off-by: Martin Schwenke <martin@...tin.net> > > I understand where you are coming from, but changing the output format > might break people with scripts doing parsing the current format. > > Since there is already a flag to ip monitor to put on prefix labels, > why not just use that if you need to? Sorry, I can't see that option in either the usage message or in the code. In the current code the only place I can see prefix_banner being set is in the "all" case. I think "prefix" is about monitoring IPv6 prefixes or similar. Perhaps I could add a "label" option instead? > This seems like a change likely to upset more people than it pleases. Yeah, perhaps... :-( peace & happiness, martin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists