netdev - Re: [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHj3AVkrjo8C802M1zOM-REks9a4V2CU_O=FH+JnK2oSwt_piw@mail.gmail.com>
Date:	Sat, 17 Aug 2013 11:12:02 +0400
From:	Denis Kirjanov <kirjanov@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Denis Kirjanov <kda@...ux-powerpc.org>, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support

On 8/17/13, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
> On 08/16/2013 09:00 PM, Denis Kirjanov wrote:
>
>     I'd rather name the patch "sundance: add netpoll support". "net-next:"
> shouldn't be there twice definitely.

Right, it was late at night so somehow I added prefix twice.
>
>> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>
>> ---
>>   drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>
>> diff --git a/drivers/net/ethernet/dlink/sundance.c
>> b/drivers/net/ethernet/dlink/sundance.c
>> index 50d9c63..2688a84 100644
>> --- a/drivers/net/ethernet/dlink/sundance.c
>> +++ b/drivers/net/ethernet/dlink/sundance.c
> [...]
>> @@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
>>   	.ndo_change_mtu		= change_mtu,
>>   	.ndo_set_mac_address 	= sundance_set_mac_addr,
>>   	.ndo_validate_addr	= eth_validate_addr,
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +	.ndo_poll_controller = sundance_poll_controller,
>
>     Could you align = here with the reset of initializers?

I'll respin.

Thanks!
>> +#endif
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Regards,
Denis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html