netdev - RE: [PATCH next] netlink: prevent deadlock in ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1DC40B07CD6EC041A66726C271A73AE61AA6F1BC@IRSMSX102.ger.corp.intel.com>
Date:	Tue, 20 Aug 2013 14:03:25 +0000
From:	"Berg, Johannes" <johannes.berg@...el.com>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	Patrick McHardy <kaber@...sh.net>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Gao feng <gaofeng@...fujitsu.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH next] netlink: prevent deadlock in ctrl_dumpfamily()

> +	if (need_locking) {
> +		/* genl_mutex could be already locked in genl_rcv_msg() */
> +		rt = genl_family_find_byid(cb->nlh->nlmsg_type);
> +		need_locking = need_locking && rt->parallel_ops;
> +	}

This is equivalent to reverting the patch because parallel_ops will be false for the genl family. :-)

johannes
-- 

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html