netdev - Re: About tcp: set timestamps for restored skb-s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130820.130806.2180396135396793576.davem@davemloft.net>
Date:	Tue, 20 Aug 2013 13:08:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	avagin@...nvz.org, netdev@...r.kernel.org
Subject: Re: About tcp: set timestamps for restored skb-s

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 17 Aug 2013 17:39:36 -0700

> Because of gmail.com problems, I missed lot of netdev traffic
> 
> Related to :
> 
> http://patchwork.ozlabs.org/patch/267678/
> 
> 
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 5423223..b2f6c74 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1121,6 +1121,13 @@  new_segment:
>  					goto wait_for_memory;
>  
>  				/*
> +				 * All packets are restored as if they have
> +				 * already been sent.
> +				 */
> +				if (tp->repair)
> +					TCP_SKB_CB(skb)->when = tcp_time_stamp;
> +
> 
> The test could be removed.
> 
> Setting @when for regular sends seems harmless

I applied this before reading this, sorry.

It can be cleaned up in net-next eventually.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html