netdev - Re: [PATCH v3] r8169: fix invalid register dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130820.150213.1489180923839317674.davem@davemloft.net>
Date:	Tue, 20 Aug 2013 15:02:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lekensteyn@...il.com
Cc:	romieu@...zoreil.com, bhutchings@...arflare.com,
	netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH v3] r8169: fix invalid register dump

From: Peter Wu <lekensteyn@...il.com>
Date: Sun, 18 Aug 2013 15:41:38 +0200

> For some reason, my PCIe RTL8111E onboard NIC on a GA-Z68X-UD3H-B3
> motherboard reads as FFs when reading from MMIO with a block size
> larger than 7. Therefore change to reading blocks of four bytes.
> 
> Ben Hutchings noted that the buffer is large enough to hold all
> registers, so now all registers are read. Since regs->len is not used
> anymore, drop the superfluous range check as well. (ethtool would
> already ensure that regs->len <= R8169_REGS_SIZE).
> 
> Signed-off-by: Peter Wu <lekensteyn@...il.com>
> ---
> Hi,
> 
> This partly obsoletes "r8169,sis190: remove unnecessary length
> check"[1]. I do not have sis190 hardware, but since that is based on
> this r8169 driver, would it make sense to apply this patch to sis190
> too?

You're going to have to respin this since I applied the length
check removal patch already.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html