netdev - Re: [PATCH] ipv6: handle Redirect ICMP Message with no Redirected Header option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5212CDA6.4070509@cn.fujitsu.com>
Date:	Tue, 20 Aug 2013 10:00:06 +0800
From:	Duan Jiong <duanj.fnst@...fujitsu.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: handle Redirect ICMP Message with no Redirected
 Header option

于 2013年08月20日 03:00, Sergei Shtylyov 写道:
> Hello.
> 
> On 08/19/2013 02:54 PM, Duan Jiong wrote:
> 
>> From: Duan Jiong <duanj.fnst@...fujitsu.com>
> 
>> rfc 4861 says the Redirected Header option is optional, so
>> the kernel should not drop the Redirect Message that has no
>> Redirected Header option. In this patch, the function
>> ip6_redirect_no_header() is introduced to deal with that
>> condition.
> 
>> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
> [...]
> 
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index b70f897..9934b87 100644
>> --- a/net/ipv6/route.c
>> +++ b/net/ipv6/route.c
>> @@ -1178,6 +1178,27 @@ void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark)
>>   }
>>   EXPORT_SYMBOL_GPL(ip6_redirect);
>>   
>> +void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif, u32 mark)
>> +{
>> +	const struct ipv6hdr *iph = (struct ipv6hdr *) skb_network_header(skb);
>> +	struct rd_msg *msg = (struct rd_msg *)skb_transport_header(skb);
> 
>    Be consistent please: either put space after a typecast or not.
> 
Thanks for you help, i will apply it in next version.

Thanks,
  Duan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html