netdev - Re: [PATCH v2 2/2] net: netem: always adjust now/delay when not reordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377091824.4226.102.camel@edumazet-glaptop>
Date:	Wed, 21 Aug 2013 06:30:24 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ferry Huberts <mailings@...ie.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/2] net: netem: always adjust now/delay when not
 reordering

On Wed, 2013-08-21 at 09:04 +0200, Ferry Huberts wrote:
> 
> On 21/08/13 08:14, Eric Dumazet wrote:
> > On Wed, 2013-08-21 at 07:59 +0200, Ferry Huberts wrote:
> >> From: Ferry Huberts <ferry.huberts@...agic.nl>
> >>
> >> Not doing this (current behaviour) introduces reordering.
> >>
> >> The packet_len_2_sched_time call is the only thing that logically
> >> depends on q->rate, so move the now/delay adjustment out of the if.
> >>
> >> How to test:
> >> -----------
> > 
> > I ask again :
> > 
> > Did you test a config with both rate limiting and delay.
> 
> (sorry for missing that question)
> 
> Just did so and with rate limiting I get no reordering, which is logical
> looking at the code.
> 
> The thing is, the evaluation q->rate is within the 'no-reordering' block
> and in the current situation you can get reordering (with that 'strange'
> command). My patch makes sure that no reordering will occur, and
> effectively 'clamps' the realised delay, which currently isn't done.


OK, let me be very clear.

I would like you post the results of regression tests, to make sure that
you do not add a new regression.

It seems that you want _us_ to check all this for you.

With "rate 1Mbits delay 100ms 10ms", and ping probes sent every 100ms,
the pong reply of _all_ probes should be between 90ms and 110ms

Is it still the case after your patch ?

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html