netdev - Re: [PATCH 4/4] qlcnic: use standard NAPI weights

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Aug 2013 22:19:04 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Michal Schmidt <mschmidt@...hat.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>,
	Himanshu Madhani <himanshu.madhani@...gic.com>,
	Rajesh Borundia <rajesh.borundia@...gic.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Sony Chacko <sony.chacko@...gic.com>,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>,
	linux-driver@...gic.com
Subject: Re: [PATCH 4/4] qlcnic: use standard NAPI weights

On 08/21/2013 08:49 PM, Michal Schmidt wrote:

> Since commit 82dc3c63 netif_napi_add() produces an error message if

    Likewise, summary line is needed.

> a NAPI poll weight greater than 64 is requested.

> qlcnic requests the weight as large as 256 for some of its rings, and
> smaller values for other rings. For instance in qlcnic_82xx_napi_add()
> I think the intention was to give the tx+rx ring a bigger weight than
> to rx-only rings, but it's actually doing the opposite. So I'm assuming
> the weights do not really matter much.

> Just use the standard NAPI weights for all rings.

> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> CC: Himanshu Madhani <himanshu.madhani@...gic.com>
> CC: Rajesh Borundia <rajesh.borundia@...gic.com>
> CC: Shahed Shaikh <shahed.shaikh@...gic.com>
> CC: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
> CC: Sony Chacko <sony.chacko@...gic.com>
> CC: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
> CC: linux-driver@...gic.com

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html