[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130820.232836.1603560215048485459.davem@davemloft.net>
Date: Tue, 20 Aug 2013 23:28:36 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: zenczykowski@...il.com
Cc: vytautas.valancius@...il.com, valas@...gle.com,
edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Passing sk_buff metadata information to user space in
TUNTAP driver.
From: Maciej Żenczykowski <zenczykowski@...il.com>
Date: Mon, 19 Aug 2013 13:49:08 -0700
> Acked-by: Maciej Żenczykowski <maze@...gle.com>
>
> I've already reviewed / commented on previous versions of this patch
> and am hoping for comments from a wider audience.
>
> I'm hoping this relatively generic and easily extensible way of
> exposing additional per-packet metadata to userspace catches on.
> Something similar would also be useful for tcpdump (ie. raw packet sockets).
I'd rather people build generic infrastructure for this.
We already have a META match in the packet scheduler, and all sorts
of BPF extensions which provide SKB metadata too. That's the right
approach, something more generic.
Therefore, putting a custom version of SKB metadata export into the
TUN driver makes absolutely no sense to me.
I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists