netdev - Re: [patch -next v2] ipip: dereferencing an ERR_PTR in ip_tunnel_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130820.233301.985050199020241179.davem@davemloft.net>
Date:	Tue, 20 Aug 2013 23:33:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	nicolas.dichtel@...nd.com, kuznet@....inr.ac.ru,
	eric.dumazet@...il.com, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next v2] ipip: dereferencing an ERR_PTR in
 ip_tunnel_init_net()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 20 Aug 2013 01:23:07 +0300

> The __ip_tunnel_create() function returns an ERR_PTR on error so we need
> to check for that before dereferencing.  This bug was added in commit
> 6c742e714d8c2 ("ipip: add x-netns support").
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2: Eric Dumazet said v1 patch looked racy and suggested the v2 fix.
> 

This doesn't apply cleanly, you'll need to respin it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html