netdev - No more checkpatch "fixes" from newer developers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 20 Aug 2013 23:44:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
CC:	netdev@...r.kernel.org
Subject: No more checkpatch "fixes" from newer developers.

I've really had it with "checkpatch" fixes that break things.

Case in point, the recent ipv6 checkpatch fixes did this:

 	/* first try to inherit the link-local address from the link device */
-	if (idev->dev->iflink &&
-	    (link_dev = __dev_get_by_index(net, idev->dev->iflink))) {
-		if (!ipv6_inherit_linklocal(idev, link_dev))
+	if (idev->dev->iflink)
+		link_dev = __dev_get_by_index(net, idev->dev->iflink);
+		if (link_dev && !ipv6_inherit_linklocal(idev, link_dev))
 			return;
-	}
+

Are you kidding me?  The openning and closing curly braces that create
the basic block were erroneously removed.  Now the value of link_dev
is not defined.

I'm reverting this, and don't bother submitting these kinds of changes
any more, I'm going to ignore them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html