netdev - Re: [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52146A6E.5030005@monstr.eu>
Date:	Wed, 21 Aug 2013 09:21:18 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Libo Chen <libo.chen@...wei.com>
CC:	davem@...emloft.net, michal.simek@...inx.com, renner@...-gmbh.de,
	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lizefan@...wei.com
Subject: Re: [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata()

On 08/21/2013 09:02 AM, Libo Chen wrote:
> Unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index 7c1ccbc..4c619ea 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
>  	lp->phy_node = NULL;
>  
>  	xemaclite_remove_ndev(ndev, of_dev);
> -	dev_set_drvdata(dev, NULL);
>  
>  	return 0;
>  }
> 

Acked-by: Michal Simek <monstr@...str.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)