netdev - Re: [PATCH net-next] net: sctp_probe: simplify code by using %pISc format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130822152623.GB16781@hmsreliant.think-freely.org>
Date:	Thu, 22 Aug 2013 11:26:23 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next] net: sctp_probe: simplify code by using %pISc
 format specifier

On Thu, Aug 22, 2013 at 05:12:50PM +0200, Daniel Borkmann wrote:
> We can simply use the %pISc format specifier that was recently added
> and thus remove some code that distinguishes between IPv4 and IPv6.
> 
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> ---
>  net/sctp/probe.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/net/sctp/probe.c b/net/sctp/probe.c
> index e62c225..cd72ae5 100644
> --- a/net/sctp/probe.c
> +++ b/net/sctp/probe.c
> @@ -155,13 +155,8 @@ static sctp_disposition_t jsctp_sf_eat_sack(struct net *net,
>  			if (sp == asoc->peer.primary_path)
>  				printl("*");
>  
> -			if (sp->ipaddr.sa.sa_family == AF_INET)
> -				printl("%pI4 ", &sp->ipaddr.v4.sin_addr);
> -			else
> -				printl("%pI6 ", &sp->ipaddr.v6.sin6_addr);
> -
> -			printl("%2u %8u %8u %8u %8u %8u ",
> -			       sp->state, sp->cwnd, sp->ssthresh,
> +			printl("%pISc %2u %8u %8u %8u %8u %8u ",
> +			       &sp->ipaddr, sp->state, sp->cwnd, sp->ssthresh,
>  			       sp->flight_size, sp->partial_bytes_acked,
>  			       sp->pathmtu);
>  		}
> -- 
> 1.7.11.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html