netdev - Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87txig3936.fsf@nemi.mork.no>
Date:	Fri, 23 Aug 2013 14:06:21 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, netdev@...r.kernel.org,
	Forest Bond <forest@...ttletooquiet.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

Dan Carpenter <dan.carpenter@...cle.com> writes:

> Ah...  Here is the first patch which adds eth_hw_addr_inherit()
>
> http://patchwork.ozlabs.org/patch/269365/
>
> I don't think we've actually set dst->addr_len yet at this point so
> it doesn't do the memcpy().  This doesn't work.

Ouch.  Yes, I see. The net_device is allocated using kzalloc just a few
lines earlier and there is no ether_setup or similar.  Actually, it
doesn't look like it ever sets addr_len. Is that right?  Does it work
even before this patch?

Anyway, thanks for spotting this.  I'll drop this patch for now as I
clearly don't understand how this driver works.

I do note that the otherwise very similar code in the vt6655 driver uses
alloc_etherdev, and therefore has a fair chance of working both before
and after my change.

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html