netdev - Re: [RFC PATCH] bridge: inherit slave devices needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFeW=pY2xT7DB-Wrpi7MSyri5UD1quR76PR5ziv+YkNmC2L5TQ@mail.gmail.com>
Date:	Fri, 23 Aug 2013 10:49:48 +0800
From:	Amos Kong <kongjianjun@...il.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	eric.dumazet@...il.com, Vlad Yasevich <vyasevic@...hat.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [RFC PATCH] bridge: inherit slave devices needed_headroom

On Tue, Aug 20, 2013 at 5:21 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> Some slave devices may have set a dev->needed_headroom value which is
> different than the default one, most likely in order to prepend a
> hardware descriptor in front of the Ethernet frame to send. Whenever a
> new slave is added to a bridge, ensure that we update the
> needed_headroom value accordingly to account for the slave
> needed_headroom value.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  net/bridge/br_if.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index aa6c9a8..c41d5fb 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -383,6 +383,9 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)
>
>         netdev_update_features(br->dev);
>
> +       if (br->dev->needed_headroom < dev->needed_headroom)
> +               br->dev->needed_headroom = dev->needed_headroom;
> +

do we need to update 'br->dev->needed_headroom' in br_del_if()?

if (br->dev->needed_headroom == dev->needed_headroom)
    br->dev->needed_headroom = ....;


>         spin_lock_bh(&br->lock);
>         changed_addr = br_stp_recalculate_bridge_id(br);
>
> --
> 1.8.1.2
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html