netdev - [PATCH ipsec-next] xfrm: announce deleation of temporary SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1377265568-10959-1-git-send-email-nicolas.dichtel@6wind.com>
Date:	Fri, 23 Aug 2013 15:46:08 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: [PATCH ipsec-next] xfrm: announce deleation of temporary SA

Creation of temporary SA are announced by netlink, but there is no notification
for the deletion.
This patch fix this asymmetric situation.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
---

Example:
ip xfrm monitor
acquire proto esp 
  sel src 10.22.6.51/32 dst 10.24.6.139/32 proto icmp type 8 code 0 
  policy src 10.22.6.51/32 dst 10.24.6.139/32 
    	dir out priority 3843 ptype main 
    	tmpl src 10.23.6.106 dst 10.23.6.206
    		proto esp reqid 2147483649 mode tunnel
Expired src 10.23.6.106 dst 10.23.6.206
	proto esp spi 0x00000000 reqid 2147483649 mode tunnel
	replay-window 0 
	sel src 10.22.6.51/32 dst 10.24.6.139/32 proto icmp type 8 code 0 
	hard 1

 net/xfrm/xfrm_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 4f8ace855864..3fd65b73df7e 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -471,7 +471,7 @@ expired:
 	}
 
 	err = __xfrm_state_delete(x);
-	if (!err && x->id.spi)
+	if (!err)
 		km_state_expired(x, 1, 0);
 
 	xfrm_audit_state_delete(x, err ? 0 : 1,
-- 
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html