netdev - Re: [net-next v2 2/8] i40e: transmit, receive, and napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130823.110415.1251655571740007987.davem@davemloft.net>
Date:	Fri, 23 Aug 2013 11:04:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sassmann@...nic.de
Cc:	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, shannon.nelson@...el.com,
	peter.p.waskiewicz.jr@...el.com, e1000-devel@...ts.sourceforge.net
Subject: Re: [net-next v2 2/8] i40e: transmit, receive, and napi

From: Stefan Assmann <sassmann@...nic.de>
Date: Fri, 23 Aug 2013 14:42:07 +0200

> On 23.08.2013 04:15, Jeff Kirsher wrote:
>> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>> 
>> This patch contains the transmit, receive, and napi routines, as well
>> as ancillary routines.
>> 
>> This file is code that is (will be) shared between the VF and PF
>> drivers.
> 
> Just some small nitpicks.
> 
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>> new file mode 100644
>> index 0000000..ceafef0
>> --- /dev/null
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> 
> [...]
> 
>> +static void i40e_receive_skb(struct i40e_ring *rx_ring,
>> +			     struct sk_buff *skb, u16 vlan_tag)
>> +{
>> +	struct i40e_vsi *vsi = rx_ring->vsi;
>> +	struct i40e_q_vector *q_vector = rx_ring->q_vector;
>> +	u64 flags = vsi->back->flags;
>> +
>> +	if (vlan_tag & VLAN_VID_MASK)
>> +		__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
> 
> Suggesting __constant_htons instead of htons here.

We don't suggest that anymore, because it's completely unnecessary
with the way the macros are implemented.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html