netdev - Re: [PATCH v5 4/5] net: ethernet: cpsw: add support for hardware interface mode config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 Aug 2013 23:18:05 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Daniel Mack <zonque@...il.com>
CC:	netdev@...r.kernel.org, bcousson@...libre.com, nsekhar@...com,
	davem@...emloft.net, ujhelyi.m@...il.com, mugunthanvnm@...com,
	vaibhav.bedia@...com, d-gerlach@...com,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v5 4/5] net: ethernet: cpsw: add support for hardware
 interface mode config

On 08/23/2013 10:53 PM, Daniel Mack wrote:

> The cpsw currently lacks code to properly set up the hardware interface
> mode on AM33xx. Other platforms might be equally affected.

> Usually, the bootloader will configure the control module register, so
> probably that's why such support wasn't needed in the past. In suspend
> mode though, this register is modified, and so it needs reprogramming
> after resume.

> This patch adds code that makes use of the previously added and optional
> support for passing the control mode register, and configures the
> correct register bits when the slave is opened.

> The AM33xx also has a bit for each slave to configure the RMII reference
> clock direction. Setting it is now supported by a per-slave DT property.

> This code path introducted by this patch is currently exclusive for
> am33xx.

> Signed-off-by: Daniel Mack <zonque@...il.com>
[...]

> @@ -40,4 +41,11 @@ struct cpsw_platform_data {
>   	u32	hw_type;	/* hardware type as specified in 'compatible' */
>   };
>
> +/* SoC specific definitions for the CONTROL port */
> +#define AM33XX_GMII_SEL_MODE_MII	(0)
> +#define AM33XX_GMII_SEL_MODE_RMII	(1)
> +#define AM33XX_GMII_SEL_MODE_RGMII	(2)

    Parens around decimal literals are hardly needed even in macros.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html