lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Aug 2013 11:11:40 +0200 From: Bjørn Mork <bjorn@...k.no> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, kaber@...sh.net Subject: Re: [PATCH] net: vlan: inherit addr_assign_type along with dev_addr David Miller <davem@...emloft.net> writes: > From: Bjørn Mork <bjorn@...k.no> > Date: Thu, 22 Aug 2013 14:23:21 +0200 > >> A vlan device inheriting a random or set address should reflect >> this in its addr_assign_type. >> >> Signed-off-by: Bjørn Mork <bjorn@...k.no> > > I think this might deserve a helper function, I'd not be surprised > if we do MAC address propagation like this in other situations and > they have the same bug. Yes. Grepping a bit shows that there area few more candidates. Although some of these could probably set addr_assign_type to NET_ADDR_STOLEN (like the bonding driver does) instead. Maybe that should depend on the addr_assign_type of the source device? Never mind. I don't know what this should look like. I'll prepare a patch set with a helper, and propose changes to all the candidate drivers I can find, leaving it up to the maintainers to object if they don't like it. Bjørn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists