netdev - Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52172B54.8020201@ti.com>
Date:	Fri, 23 Aug 2013 14:58:52 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Daniel Mack <zonque@...il.com>
CC:	<netdev@...r.kernel.org>, <sergei.shtylyov@...entembedded.com>,
	<davem@...emloft.net>, <ujhelyi.m@...il.com>,
	<mugunthanvnm@...com>, <vaibhav.bedia@...com>, <d-gerlach@...com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

On Friday 23 August 2013 02:13 PM, Daniel Mack wrote:
> This third memory region just denotes one single register in the CONTROL
> module block. The driver uses that in order to set the correct physical
> ethernet interface modes.
> 
> Also update the compatible string to make use of the am335x specific
> features of the cpsw driver.
> 
> Signed-off-by: Daniel Mack <zonque@...il.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index a785b95..1a1e9dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -446,7 +446,7 @@
>  		};
>  
>  		mac: ethernet@...00000 {
> -			compatible = "ti,cpsw";
> +			compatible = "ti,am3352-cpsw";

Please keep this as

	compatible = "ti,am3352-cpsw", "ti,cpsw";

so users can upgrade the DTB or kernel independently. Apart from this
the series looks good to me.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html