netdev - Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjs5s1dd.fsf@nemi.mork.no>
Date:	Mon, 26 Aug 2013 03:10:38 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Rob Gardner <robmatic@...il.com>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Oliver Neukum <oliver@...kum.org>
Subject: Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

Rob Gardner <robmatic@...il.com> writes:

> From 018343ce2e679d97283fb51da25c43aa876d087a Mon Sep 17 00:00:00 2001
> From: Rob Gardner <robmatic@...il.com>
> Date: Sun, 25 Aug 2013 16:02:23 -0600
> Subject: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table
>
> This patch adds another entry (HP hs2434 Mobile Broadband) to the list
> of exceptional devices that require a zero length packet in order to
> function properly. This list was added in commit 844e88f0. The hs2434
> is manufactured by Sierra Wireless, who also produces the MC7710,
> which the ZLP exception list was created for in the first place. So
> hopefully it is just this one producer's devices that will need this
> workaround.
>
> Tested on a DM1-4310NR HP notebook, which does not function without this
> change.
>
> Signed-off-by: Rob Gardner <robmatic@...il.com>

Acked-by: Bjørn Mork <bjorn@...k.no>

Thanks a lot for doing this!

As I warned about in http://www.spinics.net/lists/netdev/msg223742.html
I am now going to reconsider what do do about this issue. There are only
two devices in the exception list so far, but I would like to note that
this represents 100% of the Sierra Wireless MBIM devices we *know* are
tested with this driver.

Testing for this firmware bug and verifying the workaround on a new
device is currently hard, requiring more skills than most end users can
be expected to have. I therefore find it very likely that we will miss
(or quite possible have missed already) a number of devices which should
have been in this exception list. I believe we have to do something
about this.

Ideas are welcome.

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html