netdev - [PATCH net-next 04/16] sfc: Remove unused filter_flags variables and efx_farch_filter_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377635968.13272.73.camel@bwh-desktop.uk.level5networks.com>
Date:	Tue, 27 Aug 2013 21:39:28 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com>
Subject: [PATCH net-next 04/16] sfc: Remove unused filter_flags variables
 and efx_farch_filter_id_flags()

Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
---
 drivers/net/ethernet/sfc/filter.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/net/ethernet/sfc/filter.c b/drivers/net/ethernet/sfc/filter.c
index fb01fdb..a588c95 100644
--- a/drivers/net/ethernet/sfc/filter.c
+++ b/drivers/net/ethernet/sfc/filter.c
@@ -609,16 +609,6 @@ static inline unsigned int efx_filter_id_index(u32 id)
 	return id & EFX_FILTER_INDEX_MASK;
 }
 
-static inline u8 efx_filter_id_flags(u32 id)
-{
-	unsigned int range = id >> EFX_FILTER_INDEX_WIDTH;
-
-	if (range < EFX_FILTER_MATCH_PRI_COUNT)
-		return EFX_FILTER_FLAG_RX;
-	else
-		return EFX_FILTER_FLAG_TX;
-}
-
 u32 efx_filter_get_rx_id_limit(struct efx_nic *efx)
 {
 	struct efx_filter_state *state = efx->filter_state;
@@ -829,7 +819,6 @@ int efx_filter_remove_id_safe(struct efx_nic *efx,
 	struct efx_filter_table *table;
 	unsigned int filter_idx;
 	struct efx_filter_spec *spec;
-	u8 filter_flags;
 	int rc;
 
 	table_id = efx_filter_id_table_id(filter_id);
@@ -842,8 +831,6 @@ int efx_filter_remove_id_safe(struct efx_nic *efx,
 		return -ENOENT;
 	spec = &table->spec[filter_idx];
 
-	filter_flags = efx_filter_id_flags(filter_id);
-
 	spin_lock_bh(&state->lock);
 
 	if (test_bit(filter_idx, table->used_bitmap) &&
@@ -880,7 +867,6 @@ int efx_filter_get_filter_safe(struct efx_nic *efx,
 	struct efx_filter_table *table;
 	struct efx_filter_spec *spec;
 	unsigned int filter_idx;
-	u8 filter_flags;
 	int rc;
 
 	table_id = efx_filter_id_table_id(filter_id);
@@ -893,8 +879,6 @@ int efx_filter_get_filter_safe(struct efx_nic *efx,
 		return -ENOENT;
 	spec = &table->spec[filter_idx];
 
-	filter_flags = efx_filter_id_flags(filter_id);
-
 	spin_lock_bh(&state->lock);
 
 	if (test_bit(filter_idx, table->used_bitmap) &&


-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html