netdev - Re: sendto() bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1308270901120.1731@ja.ssi.bg>
Date:	Tue, 27 Aug 2013 09:02:16 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Chris Clark <chris.clark@...atel-lucent.com>
cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: sendto() bug?


	Hello,

On Mon, 26 Aug 2013, Chris Clark wrote:

> On Sat, 24 Aug 2013, Julian Anastasov wrote:
> > On Fri, 23 Aug 2013, Chris Clark wrote:
> > > In the same vein as 2ad5b9e4, I'm soliciting feedback on something
> > > similar for raw_sendmsg():
> [snip]
> 
> > 	So, something like
> > (inet->hdrincl ? FLOWI_FLAG_KNOWN_NH : 0) ?
> 
> 
> Many thanks.  This patch indeed appears to resolve the problem:
> 
> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> index dd44e0a..61e60d6 100644
> --- a/net/ipv4/raw.c
> +++ b/net/ipv4/raw.c
> @@ -571,7 +571,8 @@ static int raw_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
>  	flowi4_init_output(&fl4, ipc.oif, sk->sk_mark, tos,
>  			   RT_SCOPE_UNIVERSE,
>  			   inet->hdrincl ? IPPROTO_RAW : sk->sk_protocol,
> -			   inet_sk_flowi_flags(sk) | FLOWI_FLAG_CAN_SLEEP,
> +			   inet_sk_flowi_flags(sk) | FLOWI_FLAG_CAN_SLEEP |
> +			    (inet->hdrincl ? FLOWI_FLAG_KNOWN_NH : 0),

	Looks good,

Suggested-by: Julian Anastasov <ja@....bg>

>  			   daddr, saddr, 0, 0);
> 
>  	if (!inet->hdrincl) {
> 
> 
> Chris

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html