netdev - Re: [PATCH net-next] {ipv4,xfrm}: Introduce xfrm_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130827092856.GC7660@secunet.com>
Date:	Tue, 27 Aug 2013 11:28:56 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Fan Du <fan.du@...driver.com>
Cc:	David Miller <davem@...emloft.net>, saurabh.mohan@...tta.com,
	herbert@...dor.hengli.com.au, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] {ipv4,xfrm}: Introduce xfrm_tunnel_notifier for
 xfrm tunnel mode callback

On Tue, Aug 27, 2013 at 09:29:40AM +0800, Fan Du wrote:
> On 2013年08月27日 04:21, David Miller wrote:
> >
> >I don't understand why VTI doesn't need to propagate a PMTU update via
> >ipv4_update_pmtu().  Why is it different from a real xfrm_tunnel?
>   ^^^^^^^^^^^^^^^^
> 
> A IPsec protected packet is first handled by protocol handlers, e.g AH/ESP,
> to check packet authentication or encryption rightness. PMTU update is taken
> care of in this stage by protocol error handler.
> 
> Then the packet is rearranged properly depending on whether it's transport
> mode or tunnel mode packed by mode "input" handler. The VTI handler code
> takes effects in this stage in tunnel mode only. So it neither need propagate
> PMTU, as it has already been done if necessary, nor the VTI handler is
> qualified as a xfrm_tunnel.
> 

I think you are right here, please update your commit message with
the above informations. I'd take this into ipsec-next and update
the the ipv6 vti patch according to your changes if David does not
mind.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html