netdev - Re: question about drivers/net/ethernet/mellanox/mlx4/en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521DF064.7090100@mellanox.com>
Date:	Wed, 28 Aug 2013 15:43:16 +0300
From:	Amir Vadai <amirv@...lanox.com>
To:	Julia Lawall <julia.lawall@...6.fr>
CC:	<netdev@...r.kernel.org>
Subject: Re: question about drivers/net/ethernet/mellanox/mlx4/en_tx.c

On 27/08/2013 20:07, Julia Lawall wrote:
> Hello,
> 
> I was wondering why in drivers/net/ethernet/mellanox/mlx4/en_tx.c there
> are a number of uses of dma_sync_single_for_cpu without corresponding uses
> of dma_sync_single_for_device (for example in mlx4_en_rx_skb)?  In most
> drivers they come together.
> 
> thanks,
> julia
> 

Hi Julia,

I guess you meant to en_rx.c and not en_tx.c

It looks like a bug.
The whole skb buffers allocation and mapping is expected to be
overhauled soon - and this will be fixed as part of it.

Thanks,
Amir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html