netdev - Re: [net-next v2 1/8] i40e: main driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130827.213126.55332679876689993.davem@davemloft.net>
Date:	Tue, 27 Aug 2013 21:31:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shannon.nelson@...el.com
Cc:	jeffrey.t.kirsher@...el.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, jesse.brandeburg@...el.com,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next v2 1/8] i40e: main driver core

From: "Nelson, Shannon" <shannon.nelson@...el.com>
Date: Tue, 27 Aug 2013 20:34:04 +0000

> I understand the aesthetics as it does make the code look a little
> cleaner, and we can do this with a lot of our functions.  However,
> there are several instances where one declaration initialization
> depends on a previous declaration, and trying to organize by line
> length breaks these relationships.  Do you mind if we're not perfect
> on following this one?

Put the assignments that can match the ordering rule into the
declarations, put the remaining ones on seperate lines after
the declarations.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html