[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130828091208.4bcaedcf@nehalam.linuxnetplumber.net>
Date: Wed, 28 Aug 2013 09:12:08 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Cong Wang <amwang@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net-next v10 03/11] ipv6: export a stub for IPv6 symbols
used by vxlan
On Wed, 28 Aug 2013 13:22:51 +0800
Cong Wang <amwang@...hat.com> wrote:
> +struct ipv6_stub {
> + int (*ipv6_sock_mc_join)(struct sock *sk, int ifindex,
> + const struct in6_addr *addr);
> + int (*ipv6_sock_mc_drop)(struct sock *sk, int ifindex,
> + const struct in6_addr *addr);
> + int (*ipv6_dst_lookup)(struct sock *sk, struct dst_entry **dst,
> + struct flowi6 *fl6);
> + void (*udpv6_encap_enable)(void);
> +};
> +extern const struct ipv6_stub *ipv6_stub __read_mostly;
> +
Since IPv6 really can't ever be safely unloaded. why not:
* admit that, and get rid of ipv6_module exit.
* then this stub can be a static const table.
You see virtual function tables that are writeable are potential malware
targets, although eliminating all of them is impossible, I hate to
see adding new ones.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists