netdev - Re: [PATCH net-next v3 13/13] bonding: pr_debug instead of pr_warn in bond_arp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377706548.1928.16.camel@joe-AO722>
Date:	Wed, 28 Aug 2013 09:15:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Veaceslav Falico <vfalico@...hat.com>,
	Jason Baron <jbaron@...mai.com>
Cc:	netdev@...r.kernel.org, Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH net-next v3 13/13] bonding: pr_debug instead of pr_warn
 in bond_arp_send_all

(adding Jason Baron to comment on dynamic_debug)

On Wed, 2013-08-28 at 18:04 +0200, Veaceslav Falico wrote:
> They're simply annoying and will spam dmesg constantly if we hit them, so
> convert to pr_debug so that we still can access them in case of debugging.
> 
> v2: new patch
> v3: no change

Hi Veaceslav:

This changelog bit maybe is better placed below the ---

Hey Jason:

This conversion loses the net_ratelimit().

This maybe is an example of where dynamic_debug
could be better with some global rate control.

> CC: Jay Vosburgh <fubar@...ibm.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
> ---
>  drivers/net/bonding/bond_main.c |   14 ++++++--------
>  1 files changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index a52cff1..47e1052 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2336,10 +2336,8 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
>  		rt = ip_route_output(dev_net(bond->dev), targets[i], 0,
>  				     RTO_ONLINK, 0);
>  		if (IS_ERR(rt)) {
> -			if (net_ratelimit()) {
> -				pr_warning("%s: no route to arp_ip_target %pI4\n",
> -					   bond->dev->name, &targets[i]);
> -			}
> +			pr_debug("%s: no route to arp_ip_target %pI4\n",
> +				 bond->dev->name, &targets[i]);
>  			continue;
>  		}
>  
> @@ -2364,10 +2362,10 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
>  		rcu_read_unlock();
>  
>  		/* Not our device - skip */
> -		if (net_ratelimit())
> -			pr_warning("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
> -				   bond->dev->name, &targets[i],
> -				   rt->dst.dev ? rt->dst.dev->name : "NULL");
> +		pr_debug("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
> +			 bond->dev->name, &targets[i],
> +			 rt->dst.dev ? rt->dst.dev->name : "NULL");
> +
>  		ip_rt_put(rt);
>  		continue;
>  



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html