netdev - Re: [PATCH v2 net-next 1/2] qlge: Enhance nested VLAN (Q-in-Q) handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130829.013148.305467895644272769.davem@davemloft.net>
Date:	Thu, 29 Aug 2013 01:31:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jitendra.kalsaria@...gic.com
Cc:	netdev@...r.kernel.org, ron.mercer@...gic.com,
	Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH v2 net-next 1/2] qlge: Enhance nested VLAN (Q-in-Q)
 handling.

From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Date: Thu, 29 Aug 2013 00:51:07 -0400

> +	u16 *tags;
> +
> +	if (ib_mac_rsp->flags2 & IB_MAC_IOCB_RSP_V) {
> +		tags = (u16 *)page;
> +		/* Look for stacked vlan tags in ethertype field */
> +		if (tags[6] == htons(ETH_P_8021Q) &&
> +		    tags[8] == htons(ETH_P_8021Q))

htons() returns a __be16,  there is not way that this code doesn't
generate sparse endianness errors.

Also, your change is sacrificing single layered VLAN performance
for the sake of Q-in-Q as far as I can tell.  I don't think that's
a very wise tradeoff if so.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html