netdev - Re: [nf-next PATCH] netfilter: Extend SYNPROXY with a --continue option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130829102358.4f93ee24@redhat.com>
Date:	Thu, 29 Aug 2013 10:23:58 +0200
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	mph@....com, as@....com
Subject: Re: [nf-next PATCH] netfilter: Extend SYNPROXY with a --continue
 option

On Wed, 28 Aug 2013 18:00:42 +0200
Patrick McHardy <kaber@...sh.net> wrote:

> On Wed, Aug 28, 2013 at 05:26:55PM +0200, Jesper Dangaard Brouer wrote:
> > Packets reaching SYNPROXY are default dropped, as they are most likely
> > invalid (given the state matching).  In other configurations it might
> > be beneficial to let packet not consumed by SYNPROXY (SYN and ACK) to
> > continue being processed by the stack.
> > 
> > Introducing a --continue option/flag for the SYNPROXY target to allow
> > these unmatched packets to continue being processed.  This would also
> > help in debugging the module via LOG.
> 
> I don't think we should add an option for this. Just DROP packets consumed
> by the target and have the other ones continue.

I agree.  I'll send a new patch, defaulting to XT_CONTINUE.

Self:
Nacked-by: Jesper Dangaard Brouer <brouer@...hat.com>
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html