netdev - RE: [patch v2] net/fec: cleanup types in fec_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9848F2DB572E5649BA045B288BE08FBE01662A4B@039-SN2MPN1-021.039d.mgd.msft.net>
Date:	Fri, 30 Aug 2013 02:02:00 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	"David S. Miller" <davem@...emloft.net>,
	Estevam Fabio-R49496 <r49496@...escale.com>,
	Li Frank-B20596 <B20596@...escale.com>,
	Jim Baxter <jim_baxter@...tor.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch v2] net/fec: cleanup types in fec_get_mac()

From: Ben Hutchings [mailto:bhutchings@...arflare.com]
Data: Friday, August 30, 2013 2:49 AM

> To: Dan Carpenter
> Cc: Grant Likely; Rob Herring; David S. Miller; Estevam Fabio-R49496; Li
> Frank-B20596; Jim Baxter; Duan Fugang-B38611; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: Re: [patch v2] net/fec: cleanup types in fec_get_mac()
> 
> On Thu, 2013-08-29 at 11:25 +0300, Dan Carpenter wrote:
> > My static checker complains that on some arches unsigned longs can be
> > 8 characters which is larger than the buffer is only 6 chars.
> > Additionally, Ben Hutchings points out that the buffer actually holds
> > big endian data and the buffer we are reading from is CPU endian.
> 
> It's not really as clear-cut as that. :-)  But I think it's slightly more
> logical this way.
> 
Yes, it is not clear, pls remove somebody's name from the commit log.

> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>
> 
> > ---
> > v2: fix endian annotations and reverse the beXX_to_cpu() calls so that
> >     they say cpu_to_beXX().
> >
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > b/drivers/net/ethernet/freescale/fec_main.c
> > index fdf9307..0b12866 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -1100,10 +1100,10 @@ static void fec_get_mac(struct net_device *ndev)
> >  	 * 4) FEC mac registers set by bootloader
> >  	 */
> >  	if (!is_valid_ether_addr(iap)) {
> > -		*((unsigned long *) &tmpaddr[0]) =
> > -			be32_to_cpu(readl(fep->hwp + FEC_ADDR_LOW));
> > -		*((unsigned short *) &tmpaddr[4]) =
> > -			be16_to_cpu(readl(fep->hwp + FEC_ADDR_HIGH) >> 16);
> > +		*((__be32 *) &tmpaddr[0]) =
> > +			cpu_to_be32(readl(fep->hwp + FEC_ADDR_LOW));
> > +		*((__be16 *) &tmpaddr[4]) =
> > +			cpu_to_be16(readl(fep->hwp + FEC_ADDR_HIGH) >> 16);
> >  		iap = &tmpaddr[0];
> >  	}
> >
> 
> --
> Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer;
> that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
>