netdev - Re: [PATCH 05/31] net: at91_ether: use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52204F93.8050400@atmel.com>
Date:	Fri, 30 Aug 2013 09:53:55 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	"'David S. Miller'" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 05/31] net: at91_ether: use dev_get_platdata()

On 30/08/2013 07:11, Jingoo Han :
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

> ---
>   drivers/net/ethernet/cadence/at91_ether.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
> index bb5d63f..ce75de9 100644
> --- a/drivers/net/ethernet/cadence/at91_ether.c
> +++ b/drivers/net/ethernet/cadence/at91_ether.c
> @@ -304,7 +304,7 @@ MODULE_DEVICE_TABLE(of, at91ether_dt_ids);
>   /* Detect MAC & PHY and perform ethernet interface initialization */
>   static int __init at91ether_probe(struct platform_device *pdev)
>   {
> -	struct macb_platform_data *board_data = pdev->dev.platform_data;
> +	struct macb_platform_data *board_data = dev_get_platdata(&pdev->dev);
>   	struct resource *regs;
>   	struct net_device *dev;
>   	struct phy_device *phydev;
>


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html