netdev - Re: [PATCH] net: fix comment typo for __skb_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcZRD+3qTv_+=i7hnd_M2JCHmHKB8TfegPXAiTvhY8WVsA@mail.gmail.com>
Date:	Fri, 30 Aug 2013 15:18:59 +0100
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net: fix comment typo for __skb_alloc_pages()

2013/8/30 Eric Dumazet <eric.dumazet@...il.com>:
> On Fri, 2013-08-30 at 14:28 +0100, Florian Fainelli wrote:
>> The name of the function in the comment is __skb_alloc_page() while we
>> are actually commenting __skb_alloc_pages(). Fix this typo.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>  include/linux/skbuff.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
>> index 5ac96f3..3a81e4b 100644
>> --- a/include/linux/skbuff.h
>> +++ b/include/linux/skbuff.h
>> @@ -1906,7 +1906,7 @@ static inline struct sk_buff *netdev_alloc_skb_ip_align(struct net_device *dev,
>>  }
>>
>>  /*
>> - *   __skb_alloc_page - allocate pages for ps-rx on a skb and preserve pfmemalloc data
>> + *   __skb_alloc_pages - allocate pages for ps-rx on a skb and preserve pfmemalloc data
>>   *   @gfp_mask: alloc_pages_node mask. Set __GFP_NOMEMALLOC if not for network packet RX
>>   *   @skb: skb to set pfmemalloc on if __GFP_MEMALLOC is used
>>   *   @order: size of the allocation
>
> What about making this a real kerneldoc comment ?

Sure, I was not sure whether this deserved one or more patches, will
resend fixed.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html