netdev - Re: [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130830143639.GA16269@windriver.com>
Date:	Fri, 30 Aug 2013 10:36:40 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Chen Gang <gang.chen@...anux.com>
CC:	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Kees Cook <keescook@...omium.org>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] drivers: net: ethernet: 8390: Kconfig: add
 H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300

[[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote:

> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
> will no related irq and base address).

Do you have an H83000 and really know that is true?  I'm guessing no.

Looking at the driver, it is kind of broken that it only assigns I/O and
irq for two platforms, but the H8300 arch Kconfig.cpu only allows building
a single platform in a given kernel anyway, so a dependency fix is
probably acceptable here.

Given that, what you really want to indicate is something like:

  Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
  I/O base and IRQ values for the NE_H8300 driver.  Hence builds
  for other H8300H platforms will fail as per below. Since H8300H
  does not support multi platform builds, we simply limit building
  the driver to those two platforms specifically.

> 
> The release error:
> 
>     CC [M]  drivers/net/hamradio/bpqether.o
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This file has nothing to do with the problem in question.  [If you are
going to do a "make -j30" in testing, then at least restart with -j1 to
properly capture the error message.]

Please update the commit log appropriately and resubmit.

Paul.
--

>   drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
>   drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
>   drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
>   drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
>   drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
>   drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
>   drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
>   drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
>   drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
>  
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  drivers/net/ethernet/8390/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
> index a5f91e1..becef25 100644
> --- a/drivers/net/ethernet/8390/Kconfig
> +++ b/drivers/net/ethernet/8390/Kconfig
> @@ -148,7 +148,7 @@ config PCMCIA_PCNET
>  
>  config NE_H8300
>  	tristate "NE2000 compatible support for H8/300"
> -	depends on H8300
> +	depends on H8300H_AKI3068NET || H8300H_H8MAX
>  	---help---
>  	  Say Y here if you want to use the NE2000 compatible
>  	  controller on the Renesas H8/300 processor.
> -- 
> 1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html