netdev - Re: [PATCH net-next 2/6] bonding: remove the no effect lock for bond_3ad_lacpdu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Aug 2013 10:07:38 -0700
From:	Rick Jones <rick.jones2@...com>
To:	Ding Tianhong <dingtianhong@...wei.com>
CC:	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	Veaceslav Falico <vfalico@...hat.com>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/6] bonding: remove the no effect lock for bond_3ad_lacpdu_recv()

On 08/30/2013 03:04 AM, Ding Tianhong wrote:
> There is no pointer needed read lock protection, remove the unnecessary lock
> and improve performance for the 3ad recv path.

Improve performance by how much?  For example, by how much is service 
demand lower on a netperf TCP_STREAM or TCP_RR test through a bond.  I 
suppose that applies not only to this specific patch to to the set as a 
whole.

rick jones


>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> Cc: Nikolay Aleksandrov <nikolay@...hat.com>
> ---
>   drivers/net/bonding/bond_3ad.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 7a3860f..c134f43 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -2494,9 +2494,7 @@ int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
>   	if (!lacpdu)
>   		return ret;
>
> -	read_lock(&bond->lock);
>   	ret = bond_3ad_rx_indication(lacpdu, slave, skb->len);
> -	read_unlock(&bond->lock);
>   	return ret;
>   }
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html