netdev - Re: [PATCH] net: revert 8728c544a9c ("net: dev_pick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130830.174837.1340852981940136289.davem@davemloft.net>
Date:	Fri, 30 Aug 2013 17:48:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, alexander.h.duyck@...el.com,
	xii@...gle.com, therbert@...gle.com, nuclearcat@...learcat.com
Subject: Re: [PATCH] net: revert 8728c544a9c ("net: dev_pick_tx() fix")

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 28 Aug 2013 18:10:43 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit 8728c544a9cbdc ("net: dev_pick_tx() fix") and commit
> b6fe83e9525a ("bonding: refine IFF_XMIT_DST_RELEASE capability")
> are quite incompatible : Queue selection is disabled because skb
> dst was dropped before entering bonding device.
> 
> This causes major performance regression, mainly because TCP packets
> for a given flow can be sent to multiple queues.
> 
> This is particularly visible when using the new FQ packet scheduler
> with MQ + FQ setup on the slaves.
> 
> We can safely revert the first commit now that 416186fbf8c5b
> ("net: Split core bits of netdev_pick_tx into __netdev_pick_tx")
> properly caps the queue_index.
> 
> Reported-by: Xi Wang <xii@...gle.com>
> Diagnosed-by: Xi Wang <xii@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html