netdev - Re: [patch v2] net/fec: cleanup types in fec_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130830.175457.2230524537752247474.davem@davemloft.net>
Date:	Fri, 30 Aug 2013 17:54:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	grant.likely@...aro.org, rob.herring@...xeda.com,
	fabio.estevam@...escale.com, Frank.Li@...escale.com,
	jim_baxter@...tor.com, B38611@...escale.com,
	netdev@...r.kernel.org, bhutchings@...arflare.com,
	devicetree@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch v2] net/fec: cleanup types in fec_get_mac()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 29 Aug 2013 11:25:14 +0300

> My static checker complains that on some arches unsigned longs can be 8
> characters which is larger than the buffer is only 6 chars.
> Additionally, Ben Hutchings points out that the buffer actually holds
> big endian data and the buffer we are reading from is CPU endian.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2: fix endian annotations and reverse the beXX_to_cpu() calls so that
>     they say cpu_to_beXX().

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html