netdev - Re: [PATCH net-next] tcp: Remove needless check of return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130829.213627.1536495569096415942.davem@davemloft.net>
Date:	Thu, 29 Aug 2013 21:36:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	subramanian.vijay@...il.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: Remove needless check of return value

From: Vijay Subramanian <subramanian.vijay@...il.com>
Date: Thu, 29 Aug 2013 18:19:18 -0700

> After commit 0c24604b (tcp: implement RFC 5961 4.2), tcp_rcv_established() only
> returns 0 since we no longer send RSTs in response to SYNs. We can remove the
> check on the return value.
> 
> Signed-off-by: Vijay Subramanian <subramanian.vijay@...il.com>

Always returning the same value is the same as returning no value at all.

Make tcp_rcv_established() return void please.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html