netdev - Re: [PATCH net-next v12 06/11] vxlan: add ipv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130831102726.21896150@nehalam.linuxnetplumber.net>
Date:	Sat, 31 Aug 2013 10:27:26 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	David Stevens <dlstevens@...ibm.com>
Subject: Re: [PATCH net-next v12 06/11] vxlan: add ipv6 support

On Sat, 31 Aug 2013 13:44:33 +0800
Cong Wang <amwang@...hat.com> wrote:

> +#if IS_ENABLED(CONFIG_IPV6)
> +	} else {
> +		ipv6_stub->ipv6_sock_mc_join(sk, ifindex,
> +					     &ip->sin6.sin6_addr);
> +#endif

This isn't safe against IPv6 module getting unloaded. You either
have to figure out a reference count method, or disable IPv6
module unload.

Since it can only be forced unload anyway, I still argue
it should just be disabled (by removing the module exit hook
and code).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html