netdev - Re: [PATCH 15/31] net: netx-eth: use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52223333.6040903@cogentembedded.com>
Date:	Sat, 31 Aug 2013 22:17:23 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 15/31] net: netx-eth: use dev_get_platdata()

Hello.

On 08/30/2013 08:59 AM, Jingoo Han wrote:

> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.

> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>   drivers/net/ethernet/netx-eth.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/netx-eth.c b/drivers/net/ethernet/netx-eth.c
> index dc2c6f5..235fd51 100644
> --- a/drivers/net/ethernet/netx-eth.c
> +++ b/drivers/net/ethernet/netx-eth.c
> @@ -390,7 +390,7 @@ static int netx_eth_drv_probe(struct platform_device *pdev)
>
>   	priv = netdev_priv(ndev);
>
> -	pdata = (struct netxeth_platform_data *)pdev->dev.platform_data;
> +	pdata = (struct netxeth_platform_data *)dev_get_platdata(&pdev->dev);

    Cast from 'void *' is not needed. This is a material of another patch, of 
course...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html