netdev - Re: ICMPv6: treat dest unreachable codes 5 and 6 as EACCES, not EPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130901185432.GC19455@order.stressinduktion.org>
Date:	Sun, 1 Sep 2013 20:54:32 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Jiri Bohac <jbohac@...e.cz>
Cc:	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: ICMPv6: treat dest unreachable codes 5 and 6 as EACCES, not EPROTO

On Fri, Aug 30, 2013 at 11:18:45AM +0200, Jiri Bohac wrote:
> RFC 4443 has defined two additional codes for ICMPv6 type 1 (destination
> unreachable) messages:
>         5 - Source address failed ingress/egress policy
> 	6 - Reject route to destination
> 
> Now they are treated as protocol error and icmpv6_err_convert() converts them
> to EPROTO.
> 
> RFC 4443 says:
> 	"Codes 5 and 6 are more informative subsets of code 1."
> 
> Treat codes 5 and 6 as code 1 (EACCES)
> 
> Btw, connect() returning -EPROTO confuses firefox, so that fallback to
> other/IPv4 addresses does not work:
> https://bugzilla.mozilla.org/show_bug.cgi?id=910773
> 
> 
> Signed-off-by: Jiri Bohac <jbohac@...e.cz>

I would also propose it for stable.

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html