netdev - Re: Pull request: sfc-next 2013-08-30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1378142413.1552.12.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 2 Sep 2013 18:20:13 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com>
Subject: Re: Pull request: sfc-next 2013-08-30

On Sat, 2013-08-31 at 22:28 -0400, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Fri, 30 Aug 2013 04:36:34 +0100
> 
> > 1. A little more refactoring.
> > 2. Remove the unnecessary use of atomic_t that you pointed out.
> > 3. Add support for starting or queueing firmware requests from atomic
> > context.
> > 4. Add hwmon support for additional sensors found on some new boards.
> > 5. Add support for the EF10 controller architecture, the SFC9100 family
> > and specifically the SFC9120 controller.
> 
> Pulled, thanks Ben.
> 
> Maybe you can get away with just doing "atomic_inc_return()" for the
> MCDI sequence number bump and avoid the iface lock in those paths?

I haven't checked, but I think the spinlock will almost always be
uncontended.  It can bounce between CPUs, but then so will seqno.  So I
don't think that would make any significant difference to performance.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html