netdev - Re: [PATCH net-next] bcm87xx: Add MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52261D12.5000009@gmail.com>
Date:	Tue, 03 Sep 2013 10:32:02 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>,
	David Miller <davem@...emloft.net>
CC:	David Daney <david.daney@...ium.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bcm87xx: Add MODULE_DEVICE_TABLE

On 09/01/2013 02:33 PM, Ben Hutchings wrote:
> bcm87xx currently isn't auto-loaded if built as a module.
>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
> Compile-tested only.

Then how do you know that it does anything sensible?

Other than that, it seems plausible.

David Daney

>
> Ben.
>
>   drivers/net/phy/bcm87xx.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
> index 7997895..f5b44ff 100644
> --- a/drivers/net/phy/bcm87xx.c
> +++ b/drivers/net/phy/bcm87xx.c
> @@ -230,4 +230,11 @@ static void __exit bcm87xx_exit(void)
>   }
>   module_exit(bcm87xx_exit);
>
> +static struct mdio_device_id __maybe_unused bcm87xx_tbl[] = {
> +	{ PHY_ID_BCM8706, 0xffffffff },
> +	{ PHY_ID_BCM8727, 0xffffffff },
> +	{ }
> +};
> +
>   MODULE_LICENSE("GPL");
> +MODULE_DEVICE_TABLE(mdio, bcm87xx_tbl);
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html