netdev - Re: [PATCH v4] ipv6:introduce function to find route for redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130903191729.GA28889@order.stressinduktion.org>
Date:	Tue, 3 Sep 2013 21:17:29 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v4] ipv6:introduce function to find route for redirect

On Tue, Sep 03, 2013 at 01:37:19PM +0800, Duan Jiong wrote:
> > Btw. I still think it should be possible to eliminate
> > ip6_redirect_no_header:
> > 
> > We could always use ip6_redirect_no_header and use the data of the redirected
> > header option just for finding the socket to be notified. We can do the whole
> > verification and route updating in ndisc layer and then just call into icmpv6
> > layer if upper protocols need a notification of the redirect. But that should
> > go into another patch. ;)
> > 
> 
> I think this is good, but i have a question below:
> 
>   if the socket type is connection-based, the dst information is stored in related
> sock struct, so there is no need to look up the route for redirect in ip6_redirect
> or ip6_redirect_no_header, in this case, we do the verification and route 
> updating in the upper protocols' err_handler is better. 
> 
> How do you think of this?

This should not be a problem, because every cached dst should be validated
with ip6_dst_check before it is used. It uses the fib6_node serial number
which is incremented for all fib6_nodes on the path to the new installed
node by fib6_add_1. So we are safe here.

Btw. this is the same logic redirects get currently picked up, too.

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html