netdev - Re: [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Sep 2013 00:43:48 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Eric Dumazet <eric.dumazet@...il.com>, davem@...emloft.net,
	netdev@...r.kernel.org, Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages

On Tue, Sep 03, 2013 at 07:23:48PM +0100, Thomas Graf wrote:
> I'm confused why lockdep would only trigger after my patch, the
> deadlock is unrelated.

Either we had patch caf92bc ("ipv6: do not call ndisc_send_rs() with write
lock") already applied or both our testing was flawed. I reverted caf92bc and
tested v1 again and could also reproduce this problem.

Because of the sk_mc_loop logic I do think it is better to set skb->sk, so:

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

If this should still go to stable, the above mentioned commit should also hit
the queue.

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html