lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1378210806.2048.23.camel@joe-AO722>
Date:	Tue, 03 Sep 2013 05:20:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Chas Williams <chas@....nrl.navy.mil>,
	linux-atm-general@...ts.sourceforge.net,
	inux Net Dev <netdev@...r.kernel.org>,
	"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 2/2] atm: he: print MAC via %pM

On Tue, 2013-09-03 at 15:13 +0300, Andy Shevchenko wrote:
[]
> diff --git a/drivers/atm/he.c b/drivers/atm/he.c
[]
> @@ -1088,15 +1088,8 @@ static int he_start(struct atm_dev *dev)
>  	for (i = 0; i < 6; ++i)
>  		dev->esi[i] = read_prom_byte(he_dev, MAC_ADDR + i);
>  
> -	hprintk("%s%s, %x:%x:%x:%x:%x:%x\n",
> -				he_dev->prod_id,
> -					he_dev->media & 0x40 ? "SM" : "MM",
> -						dev->esi[0],
> -						dev->esi[1],
> -						dev->esi[2],
> -						dev->esi[3],
> -						dev->esi[4],
> -						dev->esi[5]);
> +	hprintk("%s%s, %*pM\n", he_dev->prod_id,
> +		he_dev->media & 0x40 ? "SM" : "MM", dev->esi);

%*pM?

Did this compile cleanly?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ