| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1378226684-7751-1-git-send-email-pshelar@nicira.com> Date: Tue, 3 Sep 2013 09:44:44 -0700 From: Pravin B Shelar <pshelar@...ira.com> To: netdev@...r.kernel.org Cc: stephen@...workplumber.org, Pravin B Shelar <pshelar@...ira.com> Subject: [PATCH net-next] vxlan: Optimize vxlan rcv vxlan-udp-recv function lookup vxlan_sock struct on every packet recv by using udp-port number. we can use sk->sk_user_data to store vxlan_sock and avoid lookup. I have open coded rcu-api to store and read vxlan_sock from sk_user_data to avoid sparse warning as sk_user_data is not __rcu pointer. Signed-off-by: Pravin B Shelar <pshelar@...ira.com> --- drivers/net/vxlan.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6b560f3..7de131f 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -916,6 +916,8 @@ void vxlan_sock_release(struct vxlan_sock *vs) spin_lock(&vn->sock_lock); hlist_del_rcu(&vs->hlist); + smp_wmb(); + vs->sock->sk->sk_user_data = NULL; spin_unlock(&vn->sock_lock); queue_work(vxlan_wq, &vs->del_work); @@ -1009,7 +1011,8 @@ static int vxlan_udp_encap_recv(struct sock *sk, struct sk_buff *skb) port = inet_sk(sk)->inet_sport; - vs = vxlan_find_sock(sock_net(sk), port); + smp_read_barrier_depends(); + vs = (struct vxlan_sock *)sk->sk_user_data; if (!vs) goto drop; @@ -2236,6 +2239,8 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, __be16 port, atomic_set(&vs->refcnt, 1); vs->rcv = rcv; vs->data = data; + smp_wmb(); + vs->sock->sk->sk_user_data = vs; spin_lock(&vn->sock_lock); hlist_add_head_rcu(&vs->hlist, vs_head(net, port)); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists